linux-kernel - Re: [PATCH] oprofile: Add support for missing Intel core i7 models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110114022950.GC4739@erda.amd.com>
Date:	Fri, 14 Jan 2011 03:29:50 +0100
From:	Robert Richter <robert.richter@....com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"oprofile-list@...ts.sf.net" <oprofile-list@...ts.sf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Shawn Bohrer <sbohrer@...advisors.com>
Subject: Re: [PATCH] oprofile: Add support for missing Intel core i7 models

On 13.01.11 19:24:35, Andi Kleen wrote:
> On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
> > On 13.01.11 17:38:11, Shawn Bohrer wrote:
> > > Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> > > Software Developer's Manual Volume 3B: System Programming Guide",
> > > Table B-1.  Tested with oprofile 0.9.6 on a:
> > > 
> > > model      : 44
> > > model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
> > > 
> > > Signed-off-by: Shawn Bohrer <sbohrer@...advisors.com>
> > 
> > Andi,
> > 
> > please ACK.
> 
> NACK -- first it's wrong because that's a westmere and westmere
> has a different event list. And the new way is to fall back to arch-perfmon
> and handle the CPUID in user space. This has been already implemented.
> So the fix is to upgrade user space.

Andi,

thanks for looking at this.

Will it be the general way in the future not to add model detection
for new Intel cpus to kernel code and instead use arch_perfmon? Are
the user land patches for cpu detection already in the oprofile
repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
patched.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/