linux-kernel - Re: vfs-scale, keep the errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Jan 2011 15:01:37 +1100
From:	Nick Piggin <npiggin@...il.com>
To:	"J. R. Okajima" <hooanon05@...oo.co.jp>
Cc:	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: vfs-scale, keep the errno

On Fri, Jan 14, 2011 at 2:38 PM, J. R. Okajima <hooanon05@...oo.co.jp> wrote:
>
> When open(2) without O_DIRECTORY opens an existing dir, it should return
> EISDIR. In do_last(), the variable 'error' is initialized EISDIR, but it
> is changed by d_revalidate() which returns any positive to represent
> 'the target dir is valid.'
> Should we keep and return the initialized 'error' in this case.

Great, thank you very much. I just changed a few variable names but
applied it. Would you please add you Signed-off-by: on patches from
now on?

Good reviewing work. Are you finding these by review or testing? I
think ltptests on an nfs mount should find this kind of bug... which I
should do.

Thanks,
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/