linux-kernel - Re: [PATCH] staging: fix build failure in bcm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110117092959.72b166af@nehalam>
Date:	Mon, 17 Jan 2011 09:29:59 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andres Salomon <dilinger@...ued.net>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Dan Carpenter <error27@...il.com>,
	Arnd Bergmann <arnd@...db.de>, devel@...verdev.osuosl.org,
	"David S.Miller" <davem@...emloft.net>
Subject: Re: [PATCH] staging: fix build failure in bcm driver

On Sat, 15 Jan 2011 07:51:45 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Le vendredi 14 janvier 2011 à 17:24 -0800, Andres Salomon a écrit :
> > While building, I hit the following:
> > 
> >   CC [M]  drivers/staging/bcm/Qos.o
> > drivers/staging/bcm/Qos.c: In function ‘PruneQueue’:
> > drivers/staging/bcm/Qos.c:367: error: ‘struct netdev_queue’ has no member named ‘tx_dropped’
> > drivers/staging/bcm/Qos.c: In function ‘flush_all_queues’:
> > drivers/staging/bcm/Qos.c:416: error: ‘struct netdev_queue’ has no member named ‘tx_dropped’
> > make[5]: *** [drivers/staging/bcm/Qos.o] Error 1
> > make[4]: *** [drivers/staging/bcm] Error 2
> > make[3]: *** [drivers/staging] Error 2
> > 
> > As well as:
> > 
> >   CC [M]  drivers/staging/bcm/Transmit.o
> > drivers/staging/bcm/Transmit.c: In function ‘SetupNextSend’:
> > drivers/staging/bcm/Transmit.c:163: error: ‘struct netdev_queue’ has no member named ‘tx_bytes’
> > drivers/staging/bcm/Transmit.c:164: error: ‘struct netdev_queue’ has no member named ‘tx_packets’
> > make[2]: *** [drivers/staging/bcm/Transmit.o] Error 1
> > 
> > 
> > tx_dropped/tx_bytes_tx_packets were removed in commit 1ac9ad13.  This patch
> > converts bcm to use net_device_stats instead of netdev_queue.
> > 
> > Signed-off-by: Andres Salomon <dilinger@...ued.net>
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> BTW, chunks included in this patch have horrible codingstyle.
> 
> Is this driver planned for inclusion sometime ?
> 

Looks like the "remove dev_txq_stats_fold" patch missed the staging driver(s).

The bcm driver code is gross, the driver should be rewritten see the TODO.

Acked-by: Stephen Hemminger <shemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/