linux-kernel - Re: [PATCH] powerpc: perf: Fix frequency calculation for overflowing counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295285881.30950.218.camel@laptop>
Date:	Mon, 17 Jan 2011 18:38:01 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Scott Wood <scottwood@...escale.com>
Cc:	Anton Blanchard <anton@...ba.org>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: perf: Fix frequency calculation for
 overflowing counters

On Mon, 2011-01-17 at 11:32 -0600, Scott Wood wrote:
> > diff --git a/arch/powerpc/kernel/perf_event.c b/arch/powerpc/kernel/perf_event.c
> > index 5674807..ab6f6be 100644
> > --- a/arch/powerpc/kernel/perf_event.c
> > +++ b/arch/powerpc/kernel/perf_event.c
> > @@ -1212,6 +1212,7 @@ static void record_and_restart(struct perf_event *event, unsigned long val,
> >                       if (left <= 0)
> >                               left = period;
> >                       record = 1;
> > +                     event->hw.last_period = event->hw.sample_period;
> >               }
> >               if (left < 0x80000000LL)
> >                       val = 0x80000000LL - left;

> Does perf_event_fsl_emb.c need this as well (it has almost the same
> record_and_restart code)? 

I would think so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/