linux-kernel - Re: [PATCH UPDATED] block: restore multiple bd_link_disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D338ABC.7020600@ce.jp.nec.com>
Date:	Mon, 17 Jan 2011 09:18:04 +0900
From:	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>
To:	Milan Broz <mbroz@...hat.com>, Tejun Heo <tj@...nel.org>
CC:	Jens Axboe <axboe@...nel.dk>, Valdis.Kletnieks@...edu,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Neil Brown <neilb@...e.de>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-raid@...r.kernel.org,
	device-mapper development <dm-devel@...hat.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Alasdair G Kergon <agk@...hat.com>
Subject: Re: [PATCH UPDATED] block: restore multiple bd_link_disk_holder()
 support

On 01/15/11 06:09, Milan Broz wrote:
> On 01/14/2011 05:10 PM, Tejun Heo wrote:
>> Commit e09b457b (block: simplify holder symlink handling) incorrectly
>> assumed that there is only one link at maximum.  dm may use multiple
>> links and expects block layer to track reference count for each link,
>> which is different from and unrelated to the exclusive device holder
>> identified by @holder when the device is opened.
>>
>> Remove the single holder assumption and automatic removal of the link
>> and revive the per-link reference count tracking.  The code
>> essentially behaves the same as before commit e09b457b sans the
>> unnecessary kobject reference count dancing.
>>
>> While at it, note that this facility should not be used by anyone else
>> than the current ones.  Sysfs symlinks shouldn't be abused like this
>> and the whole thing doesn't belong in the block layer at all.
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Reported-by: Milan Broz <mbroz@...hat.com>
>> Cc: Jun'ichi Nomura <j-nomura@...jp.nec.com>
>> Cc: Neil Brown <neilb@...e.de>
>> Cc: linux-raid@...r.kernel.org
>> Cc: Kay Sievers <kay.sievers@...y.org>
>> ---
>> Thanks for the test commands.  They were very helpful.  Can you please
>> test this one?
> 
> Hi,
> 
> yes, this one works for me. I run full lvm2 testsuite and no warnings.
> Thanks!
> 
> Tested-by: Milan Broz <mbroz@...hat.com>

Thanks Tejun, Milan!
If it passed my quick test and the lvm2 testsuite,
I have nothing to add here.
And the code looks ok, too.

-- 
Jun'ichi Nomura, NEC Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/