linux-kernel - Re: [PATCH v2] spi: New driver for Altera SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110117165958.f89e8220.sfr@canb.auug.org.au>
Date:	Mon, 17 Jan 2011 16:59:58 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Thomas Chou <thomas@...ron.com.tw>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Grant Likely <grant.likely@...retlab.ca>,
	nios2-dev@...c.et.ntust.edu.tw, Mike Frysinger <vapier@...too.org>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v2] spi: New driver for Altera SPI

Hi Thomas,

On Mon, 17 Jan 2011 13:46:40 +0800 Thomas Chou <thomas@...ron.com.tw> wrote:
>
> This patch adds a new SPI driver to support the Altera SOPC Builder
> SPI component. It uses the bitbanging library.

Just a general query.

> diff --git a/include/linux/spi/spi_altera.h b/include/linux/spi/spi_altera.h
> new file mode 100644
> index 0000000..b3d7f69
> --- /dev/null
> +++ b/include/linux/spi/spi_altera.h
> @@ -0,0 +1,12 @@
> +#ifndef _LINUX_SPI_SPI_ALTERA_H
> +#define _LINUX_SPI_SPI_ALTERA_H
> +
> +/*
> + * struct altera_spi_platform_data - platform data of the Altera SPI
> + * @interrupt:	use intrrupt driven data transfer.
> + */
> +struct altera_spi_platform_data {
> +	int interrupt;
> +};

Is there some reason that this struct definition cannot just be placed
in spi_altera.c and so save a whole extra file (and its inclusion)?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped