[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTi=D4Rcxbei2oo+EHc6X1O-2Oo+VWHAasK_JLj5W@mail.gmail.com>
Date: Sun, 16 Jan 2011 23:45:51 -0700
From: Grant Likely <grant.likely@...retlab.ca>
To: Thomas Chou <thomas@...ron.com.tw>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
David Brownell <dbrownell@...rs.sourceforge.net>,
nios2-dev@...c.et.ntust.edu.tw, Mike Frysinger <vapier@...too.org>,
devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v2] spi: New driver for Altera SPI
On Sun, Jan 16, 2011 at 11:22 PM, Thomas Chou <thomas@...ron.com.tw> wrote:
> On 01/17/2011 01:59 PM, Stephen Rothwell wrote:
>>>
>>> +/*
>>> + * struct altera_spi_platform_data - platform data of the Altera SPI
>>> + * @interrupt: use intrrupt driven data transfer.
>>> + */
>>> +struct altera_spi_platform_data {
>>> + int interrupt;
>>> +};
>>
>> Is there some reason that this struct definition cannot just be placed
>> in spi_altera.c and so save a whole extra file (and its inclusion)?
>>
>
> Hi Stephen,
>
> It is needed for board configuration file to attach this platform data,
> which is used to choose between interrupt driven data transfer or polling
> method. The data transfer rate is usually faster for polling, as interrupt
> overhead is higher.
In this case, that decision could simply be made based on whether or
not the device has an irq resource. No irq == polled mode.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists