linux-kernel - Re: [PATCH]x86: make relocatable kernel work with new binutils -resend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295312269.1949.725.camel@sli10-conroe>
Date:	Tue, 18 Jan 2011 08:57:49 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"Lu, Hongjiu" <hongjiu.lu@...el.com>,
	"Huang, Ying" <ying.huang@...el.com>
Subject: Re: [PATCH]x86: make relocatable kernel work with new binutils
 -resend

On Mon, 2011-01-17 at 18:17 +0800, Ingo Molnar wrote:
> * Shaohua Li <shaohua.li@...el.com> wrote:
> 
> > @@ -142,6 +140,11 @@ SECTIONS
> >  		CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
> >  
> >  		DATA_DATA
> > +#ifdef CONFIG_X86_32
> > +		jiffies = jiffies_64;
> > +#else
> > +		jiffies_64 = jiffies;
> > +#endif
> 
> I suspect this needs a comment, as to the unsuspecting reader it looks like black 
> magic :-)
does this one look better?


The CONFIG_RELOCATABLE is broken with new binutils, which will make boot
panic. According to Lu Hongjiu, the affected binutils are from
2.20.51.0.12 to 2.21.51.0.3, which are release since Oct 22 this year.
At least ubuntu 10.10 is using such binutils. see:
http://sourceware.org/bugzilla/show_bug.cgi?id=12327
The reason of boot panic is we have 'jiffies = jiffies_64;' in
vmlinux.lds.S. The jiffies isn't in any section. In kernel build, there
is warning saying jiffies is an absolute address and can't be
relocatable. At runtime, jiffies will have virtual address 0.

Signed-off-by: Shaohua Li<shaohua.li@...el.com>

---
 arch/x86/kernel/vmlinux.lds.S |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Index: linux/arch/x86/kernel/vmlinux.lds.S
===================================================================
--- linux.orig/arch/x86/kernel/vmlinux.lds.S	2011-01-18 08:32:22.000000000 +0800
+++ linux/arch/x86/kernel/vmlinux.lds.S	2011-01-18 08:57:09.000000000 +0800
@@ -34,11 +34,9 @@ OUTPUT_FORMAT(CONFIG_OUTPUT_FORMAT, CONF
 #ifdef CONFIG_X86_32
 OUTPUT_ARCH(i386)
 ENTRY(phys_startup_32)
-jiffies = jiffies_64;
 #else
 OUTPUT_ARCH(i386:x86-64)
 ENTRY(phys_startup_64)
-jiffies_64 = jiffies;
 #endif
 
 #if defined(CONFIG_X86_64) && defined(CONFIG_DEBUG_RODATA)
@@ -142,6 +140,15 @@ SECTIONS
 		CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
 
 		DATA_DATA
+		/*
+		 * Workaround a binutils (2.20.51.0.12 to 2.21.51.0.3) bug.
+		 * This makes jiffies relocatable in such binutils
+		 */
+#ifdef CONFIG_X86_32
+		jiffies = jiffies_64;
+#else
+		jiffies_64 = jiffies;
+#endif
 		CONSTRUCTORS
 
 		/* rarely changed data like cpu maps */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/