linux-kernel - Re: [PATCH] param: add null statement to compiled-in module params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201101181139.21779.rusty@rustcorp.com.au>
Date:	Tue, 18 Jan 2011 11:39:21 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH] param: add null statement to compiled-in module params

On Mon, 17 Jan 2011 06:42:13 pm Linus Walleij wrote:
> On 01/17/2011 12:41 AM, Rusty Russell wrote:
> > On Wed, 5 Jan 2011 10:57:04 pm Linus Walleij wrote:
> >    
> >> Add an unused struct declaration statement requiring a
> >> terminating semicolon to the compile-in case to provoke an
> >> error if __MODULE_INFO() is used without the terminating
> >> semicolon. Previously MODULE_ALIAS("foo") (no semicolon)
> >> compiled fine if MODULE was not selected.
> >>      
> > I really prefer the other way; make everyone use a semicolon.
> >    
> 
> That's what it does. Currently the kernel allows you to
> write MODULE_ALIAS("bar") sans semicolon if you
> compile in the module statically...
> 
> Or am I getting things wrong?

No, I was.  Sorry, I should read more carefully.

Applied, thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/