linux-kernel - Re: [PATCH 04/16] input: tnetv107x-touchscreen: don't treat NULL clk as an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110118043555.GA23851@core.coreip.homeip.net>
Date:	Mon, 17 Jan 2011 20:35:55 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Jamie Iles <jamie@...ieiles.com>
Cc:	linux-kernel@...r.kernel.org, Cyril Chemparathy <cyril@...com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 04/16] input: tnetv107x-touchscreen: don't treat NULL clk
 as an error

On Mon, Jan 17, 2011 at 08:25:35PM -0800, Dmitry Torokhov wrote:
> On Tue, Jan 11, 2011 at 09:56:41PM -0800, Dmitry Torokhov wrote:
> > On Tue, Jan 11, 2011 at 12:43:41PM +0000, Jamie Iles wrote:
> > > clk_get() returns a struct clk cookie to the driver and some platforms
> > > may return NULL if they only support a single clock.  clk_get() has only
> > > failed if it returns a ERR_PTR() encoded pointer.
> > > 
> > > Cc: Cyril Chemparathy <cyril@...com>
> > > Cc: linux-input@...r.kernel.org
> > > Signed-off-by: Jamie Iles <jamie@...ieiles.com>
> > 
> > Applied both, thank you Jamie.
> > 
> 
> Actually, if we pass clk that is NULL along we going to get oops on many
> arches, so I am going to change it to IS_ERR_OR_NULL.
> 

Oh, wait... OK, I got confused by the changelog. IS_ERR is proper,
sorry.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/