linux-kernel - Re: [PATCH 05/17][trivial] drivers/message/, i2o: Remove unnecessary casts of void ptr returning alloc function return values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101191524580.26685@pobox.suse.cz>
Date:	Wed, 19 Jan 2011 15:25:19 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 05/17][trivial] drivers/message/, i2o: Remove unnecessary
 casts of void ptr returning alloc function return values

On Tue, 9 Nov 2010, Jesper Juhl wrote:

> The [vk][cmz]alloc(_node) family of functions return void pointers which
> it's completely unnecessary/pointless to cast to other pointer types since
> that happens implicitly.
> 
> This patch removes such casts from drivers/message/
> 
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  i2o_config.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
> index 7d3cc57..098de2b 100644
> --- a/drivers/message/i2o/i2o_config.c
> +++ b/drivers/message/i2o/i2o_config.c
> @@ -1044,8 +1044,7 @@ static long i2o_cfg_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
>  
>  static int cfg_open(struct inode *inode, struct file *file)
>  {
> -	struct i2o_cfg_info *tmp =
> -	    (struct i2o_cfg_info *)kmalloc(sizeof(struct i2o_cfg_info),
> +	struct i2o_cfg_info *tmp = kmalloc(sizeof(struct i2o_cfg_info),
>  					   GFP_KERNEL);
>  	unsigned long flags;

Not present in linux-next as of today. Applied, thanks Jesper.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/