linux-kernel - Re: [PATCH] usb otg: use atomic notifier instead of blocking notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110119160102.GA4629@legolas.emea.dhcp.ti.com>
Date:	Wed, 19 Jan 2011 18:01:02 +0200
From:	Felipe Balbi <balbi@...com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	balbi@...com, Yang Ruirui <ruirui.r.yang@...to.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Felipe Balbi <felipe.balbi@...ia.com>,
	Heikki Krogerus <ext-heikki.krogerus@...ia.com>,
	Tejun Heo <tj@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>, Hema HK <hemahk@...com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb otg: use atomic notifier instead of blocking
 notifier

On Wed, Jan 19, 2011 at 11:38:44PM +0800, Ming Lei wrote:
> Hi,
> 
> 2011/1/19 Felipe Balbi <balbi@...com>:
> 
> > that's easy to guess since commit log says it's a problem on Meego
> > kernel.
> 
> OK, it is a specific issue on Meego kernel, so it is better to add
> "Meego " in the patch title.
> 
> >
> >> Are you sure the issue can be reproduced in 2.6.37 or -next tree?
> >>
> >> In mainline code(2.6.37), blocking_notifier_call_chain is only called in
> >> threaded irq handler of otg driver wrt. musb driver, so seems enough.
> >
> > true, but seems like Nokia is using to notify gadget states, which makes
> > a lot of sense when you start thinking about things such as battery
> > charging.
> 
> Please go ahead to submit and merge it into mainline first if it makes
> sense, :-)

isn't it what his patch is already intending to do ? Or do you want them
to send the initial buggy version and only afterwards send the bugfix ?
A bit weird decision wouldn't that be ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/