linux-kernel - Re: [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Jan 2011 09:44:12 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	tapio.vihuri@...ia.com
Cc:	peter.ujfalusi@...ia.com, randy.dunlap@...cle.com,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	ilkka.koskinen@...ia.com, samu.p.onkalo@...ia.com
Subject: Re: [PATCH v4 1/3] ECI: input: introduce ECI accessory input driver

Hi Tapio,

On Wed, Jan 19, 2011 at 02:06:54PM +0200, tapio.vihuri@...ia.com wrote:
> +
> +	for (; key->type != KE_END; key++) {
> +		switch (key->type) {
> +		case KE_KEY:
> +			__set_bit(key->keycode, eci->acc_input->keybit);
> +			break;
> +		case KE_SW:
> +		case KE_VSW:
> +			__set_bit(key->keycode, eci->acc_input->swbit);
> +			break;
> +		}
> +	}
> +

Is this still needed? I believe sparse_keymap_setup() below shoudl take
care of this...

> +	__set_bit(EV_KEY, eci->acc_input->evbit);
> +	__set_bit(EV_SW, eci->acc_input->evbit);
> +	__set_bit(EV_REP, eci->acc_input->evbit);
> +
> +	err = sparse_keymap_setup(eci->acc_input, eci_keymap, NULL);
> +	if (err)
> +		goto err_free_dev;
> +

Haven't looked at the rest yet...

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/