linux-kernel - Re: [PATCH v6] input: tegra-kbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110119225834.GA29284@core.coreip.homeip.net>
Date:	Wed, 19 Jan 2011 14:58:34 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	riyer@...dia.com
Cc:	tsoni@...eaurora.org, pavel@....cz, shubhrajyoti@...com,
	ccross@...roid.com, konkers@...roid.com, olof@...om.net,
	achew@...dia.com, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v6] input: tegra-kbc - Add tegra keyboard driver

On Wed, Jan 19, 2011 at 02:30:07PM -0800, riyer@...dia.com wrote:
> +
> +static void tegra_kbc_report_keys(struct tegra_kbc *kbc)
> +{
> +	unsigned char scancodes[KBC_MAX_KPENT];
> +	unsigned short keycodes[KBC_MAX_KPENT];
> +	u32 val = 0;
> +	unsigned int i;
> +	unsigned int num_down = 0;
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&kbc->lock, flags);
> +	for (i = 0; i < KBC_MAX_KPENT * 4; i++) {

This will cause going beyond scancodes[] and keycodes[] and stomping on
your stack...

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/