linux-kernel - Re: [PATCH 1/3] watchdog: fix broken nowatchdog logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110119002340.GB31465@redhat.com>
Date:	Tue, 18 Jan 2011 19:23:40 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, stable@...nel.org
Subject: Re: [PATCH 1/3] watchdog: fix broken nowatchdog logic

On Tue, Jan 18, 2011 at 11:37:44PM +0100, Marcin Slusarz wrote:
> Passing nowatchdog to kernel disables 2 things: creation of watchdog threads
> AND initialization of percpu watchdog_hrtimer. As hrtimers are initialized
> only at boot it's not possible to enable watchdog later - for me all watchdog
> threads started to eat 100% of CPU time, but they could just crash.
> 
> Additionally, even if these threads would start properly,
> watchdog_disable_all_cpus was guarded by no_watchdog check, so you
> couldn't disable watchdog.
> 
> To fix this, remove no_watchdog variable and use already existing
> watchdog_enabled variable.

These three patches seem reasonable.  I'll queue them up.

Thanks,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/