linux-kernel - Re: [PATCH v5] input: tegra-kbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110119052324.GA27751@core.coreip.homeip.net>
Date:	Tue, 18 Jan 2011 21:23:24 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Rakesh Iyer <riyer@...dia.com>
Cc:	"tsoni@...eaurora.org" <tsoni@...eaurora.org>,
	"pavel@....cz" <pavel@....cz>,
	"shubhrajyoti@...com" <shubhrajyoti@...com>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"konkers@...roid.com" <konkers@...roid.com>,
	"olof@...om.net" <olof@...om.net>, Andrew Chew <AChew@...dia.com>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH v5] input: tegra-kbc - Add tegra keyboard driver

On Tue, Jan 18, 2011 at 07:28:29PM -0800, Rakesh Iyer wrote:
> Sorry for the late response as I was not working on it on Monday.
> 
> The patch as is did not work. I am debugging this currently.

Sorry about that. If you describe the effects you are seeing I might try
to think where I messed up.

> 
> Once I find a fix, can I resend all the driver code as one patch file?
> I will include your 2nd patch in it as well.

Sure.

> 
> Secondly, the driver is a platform driver for Tegra platforms. The
> platform code needs some of the #defines to be present in kbc.h, so
> you will see some of the defines moved back to kbc.h from tegra-kbc.c
> 

I only moved KBC_MAX_COL, KBC_MAX_ROW and KBC_MAX_KEY since they are
not needed in keymaps expressed via struct matrix_keypad_data. But if
they are needed for something else that's fine.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/