| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jan 2011 06:21:03 +0000 From: Chris Ball <cjb@...top.org> To: "Dong, Chuanxiao" <chuanxiao.dong@...el.com> Cc: "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "akpm@...ux-foundation.org" <akpm@...ux-foundation.org> Subject: Re: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature Hi Chuanxiao, On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote: > > I think these should probably be printed in decimal instead of hex. (Will assume you agree with this, let me know if not.) > > Hm, this way the sysfs files will show up regardless of whether we have > > an eMMC device or an SD card, which is very confusing. Can you not check > > whether enhanced_area_en == 1 before create these files? > > > SD card will not use this code when initializing. So I think these files only are created for eMMC card. If the eMMC card doesn't support enhanced area, can we use the same way like below scenario, exporting some value like -EINVAL to user? What do you think? Oh, makes sense -- I agree, let's just use -EINVAL, and update the sysfs ABI doc to mention that. Thanks! -- Chris Ball <cjb@...top.org> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists