linux-kernel - Re: [Patch] printk: move some loglevel setup functions to kernel/printk.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Jan 2011 15:36:55 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Tejun Heo <tj@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	James Morris <jmorris@...ei.org>,
	Kees Cook <kees.cook@...onical.com>,
	Namhyung Kim <namhyung@...il.com>
Subject: Re: [Patch] printk: move some loglevel setup functions to kernel/printk.c

于 2011年01月20日 04:18, Andrew Morton 写道:
>> Cc: WANG Cong<amwang@...hat.com>, Ingo Molnar<mingo@...e.hu>  (commit_signer:8/43=19%,commit_signer:4/26=15%), Andrew Morton<akpm@...ux-foundation.org>  (commit_signer:7/43=16%,commit_signer:9/26=35%), Peter Zijlstra<a.p.zijlstra@...llo.nl>  (commit_signer:5/43=12%), Tejun Heo<tj@...nel.org>  (commit_signer:4/43=9%), Arnd Bergmann<arnd@...db.de>  (commit_signer:3/43=7%), James Morris<jmorris@...ei.org>  (commit_signer:6/26=23%), Kees Cook<kees.cook@...onical.com>  (commit_signer:4/26=15%), Namhyung Kim<namhyung@...il.com>  (commit_signer:3/26=12%)
>
> Pease don't do that.
>

Sorry for this, I used get_maintainers.pl in my script,
and now I fixed my script. :-/

> On Wed, 19 Jan 2011 15:29:24 +0800
> Amerigo Wang<amwang@...hat.com>  wrote:
>
>> These parameter setup functions should go to kernel/printk.c,
>
> That makes sense.
>
>> and should also be under CONFIG_PRINTK.
>
> Not so sure about that.  console_loglevel pertains to the console
> system more than to printk.  And the console layer is present even when
> CONFIG_PRINTK=n.


Such as?

>
> Now, it may be that console_loglevel never does anything useful when
> CONFIG_PRINTK=n.  In which case one wonders why the console code exists
> when CONFIG_PRINTK=n.
>
> Anyway.  I didn't look at all this terribly hard.  Please demonstrate
> to us that you did do so :)
>

With CONFIG_PRINTK=n we still have consoles and can still register
other consoles, but there will be no messages printed from kernel
to console. So, I think "quiet" is only meaningful to CONFIG_PRINTK=y.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/