linux-kernel - Re: [PATCH] Coding style in serial2002

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110120075336.GA5888@legolas.emea.dhcp.ti.com>
Date:	Thu, 20 Jan 2011 09:53:36 +0200
From:	Felipe Balbi <balbi@...com>
To:	ahern.michael.t@...il.com
Cc:	gregkh@...e.de, u.kleine-koenig@...gutronix.de, julia@...u.dk,
	nikai@...ai.net, morgan.gatti@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Coding style in serial2002

On Thu, Jan 20, 2011 at 06:50:02PM +1100, ahern.michael.t@...il.com wrote:
> From: Michael Ahern <ahern.michael.t@...il.com>
> 
> This patch resolves braces and KERN_ warnings by checkpatch.pl
> Warnings: printk() should include KERN_ facility level, removed unnecessary braces, lines over 80 chars

break the commit log in 72 chars

> @@ -246,7 +246,12 @@ static void tty_setspeed(struct file *f, int speed)
>  		struct termios settings;
>  
>  		tty_ioctl(f, TCGETS, (unsigned long)&settings);
> -/* printk("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX)); */
> +
> +		/* printk("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX));
> +		 * better
> +		 * pr_info("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX));
> +		 */

since you're fixing coding style, you might as well use the correct
multi-line comment style:

/*
 * printk(....
 * better
 * pr_info(....
 */

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/