linux-kernel - Re: Checkpatch problem with Kconfig help symbol ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D380279.4070502@suse.cz>
Date:	Thu, 20 Jan 2011 10:38:01 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>,
	tapio.vihuri@...ia.com
Subject: Re: Checkpatch problem with Kconfig help symbol ?

On 20.1.2011 09:06, WANG Cong wrote:
> On Wed, 19 Jan 2011 14:42:48 +0200, Tapio Vihuri wrote:
> 
>> Hi
>>
>> Is this false positive ?
>>
>> WARNING: please write a paragraph that describes the config symbol fully
>> #60: FILE: drivers/input/misc/Kconfig:159: +       help
>>
>>
>> Interesting enough, also:
>>
>> ./scripts/checkpatch.pl --file drivers/input/misc/Kconfig WARNING:
>> please write a paragraph that describes the config symbol fully #430:
>> FILE: input/misc/Kconfig:430:
>> +       help
>>
>>
>> But this is different line.
>>
> 
> Seems yes, the Kconfig part of your patch looks fine.

The check is complaining that the help text is too short:

+config ECI_CTRL_DEBUG
+	bool "ECI controller debug"
+	depends on INPUT_ECI_AT20
+	help
+	  Say Y here to enable debugging messages for ECI controller driver.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/