linux-kernel - [PATCH] ARM: mm: Regarding section when dealing with meminfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1295516739-9839-1-git-send-email-pullip.cho@samsung.com>
Date:	Thu, 20 Jan 2011 18:45:39 +0900
From:	KyongHo Cho <pullip.cho@...sung.com>
To:	linux-arm-kernel@...ts.infradead.org, linux-mm@...ck.org
Cc:	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Ilho Lee <ilho215.lee@...sung.com>,
	KeyYoung Park <keyyoung.park@...sung.com>,
	KyongHo Cho <pullip.cho@...sung.com>
Subject: [PATCH] ARM: mm: Regarding section when dealing with meminfo

Sparsemem allows that a bank of memory spans over several adjacent
sections if the start address and the end address of the bank
belong to different sections.
When gathering statictics of physical memory in mem_init() and
show_mem(), this possiblity was not considered.

This patch guarantees that simple increasing the pointer to page
descriptors does not exceed the boundary of a section.

Signed-off-by: KyongHo Cho <pullip.cho@...sung.com>
---
 arch/arm/mm/init.c |   74 +++++++++++++++++++++++++++++++++++----------------
 1 files changed, 51 insertions(+), 23 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 57c4c5c..6ccecbe 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -93,24 +93,38 @@ void show_mem(void)
 
 		pfn1 = bank_pfn_start(bank);
 		pfn2 = bank_pfn_end(bank);
-
+#ifndef CONFIG_SPARSEMEM
 		page = pfn_to_page(pfn1);
 		end  = pfn_to_page(pfn2 - 1) + 1;
-
+#else
+		pfn2--;
 		do {
-			total++;
-			if (PageReserved(page))
-				reserved++;
-			else if (PageSwapCache(page))
-				cached++;
-			else if (PageSlab(page))
-				slab++;
-			else if (!page_count(page))
-				free++;
-			else
-				shared += page_count(page) - 1;
-			page++;
-		} while (page < end);
+			page = pfn_to_page(pfn1);
+			if (pfn_to_section_nr(pfn1) < pfn_to_section_nr(pfn2)) {
+				pfn1 += PAGES_PER_SECTION;
+				pfn1 &= PAGE_SECTION_MASK;
+			} else {
+				pfn1 = pfn2;
+			}
+			end = pfn_to_page(pfn1) + 1;
+#endif
+			do {
+				total++;
+				if (PageReserved(page))
+					reserved++;
+				else if (PageSwapCache(page))
+					cached++;
+				else if (PageSlab(page))
+					slab++;
+				else if (!page_count(page))
+					free++;
+				else
+					shared += page_count(page) - 1;
+				page++;
+			} while (page < end);
+#ifdef CONFIG_SPARSEMEM
+		} while (pfn1 < pfn2);
+#endif
 	}
 
 	printk("%d pages of RAM\n", total);
@@ -470,17 +484,31 @@ void __init mem_init(void)
 
 		pfn1 = bank_pfn_start(bank);
 		pfn2 = bank_pfn_end(bank);
-
+#ifndef CONFIG_SPARSEMEM
 		page = pfn_to_page(pfn1);
 		end  = pfn_to_page(pfn2 - 1) + 1;
-
+#else
+		pfn2--;
 		do {
-			if (PageReserved(page))
-				reserved_pages++;
-			else if (!page_count(page))
-				free_pages++;
-			page++;
-		} while (page < end);
+			page = pfn_to_page(pfn1);
+			if (pfn_to_section_nr(pfn1) < pfn_to_section_nr(pfn2)) {
+				pfn1 += PAGES_PER_SECTION;
+				pfn1 &= PAGE_SECTION_MASK;
+			} else {
+				pfn1 = pfn2;
+			}
+			end = pfn_to_page(pfn1) + 1;
+#endif
+			do {
+				if (PageReserved(page))
+					reserved_pages++;
+				else if (!page_count(page))
+					free_pages++;
+				page++;
+			} while (page < end);
+#ifdef CONFIG_SPARSEMEM
+		} while (pfn1 < pfn2);
+#endif
 	}
 
 	/*
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/