linux-kernel - Re: [PATCH 0/2] HID: roccat: Add support for Arvo, small bugfix and a question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1101201129020.29002@pobox.suse.cz>
Date:	Thu, 20 Jan 2011 11:29:51 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 0/2] HID: roccat: Add support for Arvo, small bugfix and
 a question

On Thu, 6 Jan 2011, Stefan Achatz wrote:

> This patchset adds support for the Roccat Arvo keyboard.
> The driver is similar to my other roccat drivers.

Applied, thanks for the driver, Stefan.

> I'm now finished implementing new device support and my next step would 
> be to abstract similarities to reduce code duplication.

That would be very welcome.

> Has the resulting file to be a module named like "roccat-common" that 
> has to be selected as depencendy in Kconfig or is there another 
> mechanism to hide this gratuitous decicion from the user?

Yes, I think this would be a reasonable implementation in this case.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/