linux-kernel - Re: [PATCH] RFC: abstract access to xtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110120173029.GA26121@infradead.org>
Date:	Thu, 20 Jan 2011 12:30:29 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Torben Hohn <torbenh@....de>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...x.de>
Subject: Re: [PATCH] RFC: abstract access to xtime_lock into a set of inline
 functions

On Thu, Jan 20, 2011 at 06:14:08PM +0100, Torben Hohn wrote:
> the -rt patches change the xtime_lock to a raw_seqlock_t
> so a pretty huge portion of the patch deals with changing
> the locking functions.
> 
> this commit uses inline functions, to hide the type
> of the lock.

That's not how kernel code usually works.

> -	write_seqlock(&xtime_lock);
> +	xtime_write_seqlock();
>  	do_timer(1);
> -	write_sequnlock(&xtime_lock);
> +	xtime_write_sequnlock();

However there's a pretty clear pattern of taking xtime_lock, calling
do_timer and then releasing.  A useful thing you could do is to rename
do_timer to do_timer_locked and make do_timer take and release
xtime_lock in one place.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/