linux-kernel - Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=2Tx7M4=wF7GkQZLFe5=JLGv2G7roavKroWZ78@mail.gmail.com>
Date:	Thu, 20 Jan 2011 13:48:24 -0500
From:	Eric Miao <eric.y.miao@...il.com>
To:	Sven Neumann <s.neumann@...mfeld.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Lennert Buijtenhek <buytenh@...tstofly.org>,
	linux-arm-kernel@...ts.infradead.org,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...aq.de>
Subject: Re: [PATCH] pxa3xx: fix PXA GPIO IRQ handling

On Tue, Jan 18, 2011 at 4:49 PM, Sven Neumann <s.neumann@...mfeld.com> wrote:
> On Tue, 2011-01-18 at 08:15 -0800, Eric Miao wrote:
>> On Tue, Jan 18, 2011 at 3:47 AM, Lars-Peter Clausen <lars@...afoo.de> wrote:
>> > On 01/18/2011 09:18 AM, Sven Neumann wrote:
>> >> From: Lars-Peter Clausen <lars@...afoo.de>
>> >>
>> >> Set the "set_wake" field of the irq_chip struct before calling
>> >> set_irq_chip() for all of the IRQs, so that the compat handler
>> >> actually gets installed.
>>
>> Not really sure if this is necessary. Lennert has done the transition to
>> irq_data to those _set_wake() functions as well, so it should be OK
>> that compat handler doesn't get installed.
>>
>> Now I'm not against moving this above, just wondering if there were
>> any consequences/errors coming out?
>
> Well, our PXA300 device doesn't power up again when it should resume
> from suspend. Fine with me if this has been fixed upstream,

Yeah, that's true. Mind re-post with your SOB?

> but I would
> still like to get this patch into 2.6.37. I'll try to test upstream as
> soon as Linus releases 2.6.38-rc1...
>
>
> Sven
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/