linux-kernel - Re: [patch 36/37] tile: Use generic irq Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Jan 2011 20:08:18 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Chris Metcalf <cmetcalf@...era.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch 36/37] tile: Use generic irq Kconfig

On Thu, Jan 20, 2011 at 01:54:27PM -0500, Chris Metcalf wrote:
> On 1/19/2011 4:50 PM, Thomas Gleixner wrote:
> > No functional change.
> >
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Chris Metcalf <cmetcalf@...era.com>
> > ---
> >  arch/tile/Kconfig |   16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> >
> > Index: linux-2.6/arch/tile/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/arch/tile/Kconfig
> > +++ linux-2.6/arch/tile/Kconfig
> > @@ -1,22 +1,18 @@
> >  # For a description of the syntax of this configuration file,
> >  # see Documentation/kbuild/config-language.txt.
> >  
> > +config TILE
> > +       def_bool y
> > +       select HAVE_GENERIC_HARDIRQS
> > +       select GENERIC_IRQ_PROBE
> > +       select GENERIC_PENDING_IRQ if SMP
> > +
> >  [...]
> 
> I'm not sure it's legal to have two "config TILE" blocks in this Kconfig
> file; there's already one further down.

It is OK to have two "config TILE" blocks.
You should take care of moving the other one up after this goes in.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/