linux-kernel - Re: [REPOST] [PATCH 3/3] Provide control over unmapped pages (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110121072315.GL2897@balbir.in.ibm.com>
Date:	Fri, 21 Jan 2011 12:53:15 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	linux-mm@...ck.org, akpm@...ux-foundation.org, npiggin@...nel.dk,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	kosaki.motohiro@...fujitsu.com, kamezawa.hiroyu@...fujitsu.com
Subject: Re: [REPOST] [PATCH 3/3] Provide control over unmapped pages (v3)

* Christoph Lameter <cl@...ux.com> [2011-01-20 09:00:09]:

> On Thu, 20 Jan 2011, Balbir Singh wrote:
> 
> > +	unmapped_page_control
> > +			[KNL] Available if CONFIG_UNMAPPED_PAGECACHE_CONTROL
> > +			is enabled. It controls the amount of unmapped memory
> > +			that is present in the system. This boot option plus
> > +			vm.min_unmapped_ratio (sysctl) provide granular control
> 
> min_unmapped_ratio is there to guarantee that zone reclaim does not
> reclaim all unmapped pages.
> 
> What you want here is a max_unmapped_ratio.
>

I thought about that, the logic for reusing min_unmapped_ratio was to
keep a limit beyond which unmapped page cache shrinking should stop.
I think you are suggesting max_unmapped_ratio as the point at which
shrinking should begin, right?
 
> 
> >  {
> > @@ -2297,6 +2320,12 @@ loop_again:
> >  				shrink_active_list(SWAP_CLUSTER_MAX, zone,
> >  							&sc, priority, 0);
> >
> > +			/*
> > +			 * We do unmapped page reclaim once here and once
> > +			 * below, so that we don't lose out
> > +			 */
> > +			reclaim_unmapped_pages(priority, zone, &sc);
> > +
> >  			if (!zone_watermark_ok_safe(zone, order,
> 
> Hmmmm. Okay that means background reclaim does it. If so then we also want
> zone reclaim to be able to work in the background I think.

Anything specific you had in mind, works for me in testing, but is
there anything specific that stands out in your mind that needs to be
done?

Thanks for the review!
 

-- 
	Three Cheers,
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/