linux-kernel - Re: [PATCH] acpi: debugfs: fix buffer overflows, double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTik3TT-0L3OOw2t19tufnOKtLBSCUt91S5V6cg6N@mail.gmail.com>
Date:	Fri, 21 Jan 2011 17:37:49 +0800
From:	Eugene Teo <eugeneteo@...nel.sg>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] acpi: debugfs: fix buffer overflows, double free

On 1/21/11, WANG Cong <xiyou.wangcong@...il.com> wrote:
> On Thu, 20 Jan 2011 23:08:06 +0300, Vasiliy Kulikov wrote:
>
>> File position is not controlled, it may lead to overwrites of arbitrary
>> kernel memory.  Also the code may kfree() the same pointer multiple
>> times.
>>
>> One more flaw is still present: if multiple processes open the file then
>> all 3 static variables are shared, leading to various race conditions.
>> They should be moved to file->private_data.
>>
>> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
>
> Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

Reviewed-by: Eugene Teo <eugeneteo@...nel.org>

Thanks, Eugene
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/