linux-kernel - [PATCH] UBI: fix unaligned leb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zkqu1fuh.fsf@vostro.fn.ogness.net>
Date:	Fri, 21 Jan 2011 15:39:02 +0100
From:	John Ogness <john.ogness@...utronix.de>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] UBI: fix unaligned leb_start value

From: John Ogness <john.ogness@...utronix.de>

The wrong header size was used in calculating the data offset. The
data offset should be VID header offset + VID header size (aligned to
the minimum I/O unit).

Signed-off-by: John Ogness <john.ogness@...utronix.de>
---
This patch is against linux-next-20110121.

Since the value is later aligned, this patch does not fix any real
world problem. But it should be fixed nonetheless.

 drivers/mtd/ubi/build.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index f49e49d..a4f47dd 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -737,7 +737,7 @@ static int io_init(struct ubi_device *ubi)
 	}
 
 	/* Similar for the data offset */
-	ubi->leb_start = ubi->vid_hdr_offset + UBI_EC_HDR_SIZE;
+	ubi->leb_start = ubi->vid_hdr_offset + UBI_VID_HDR_SIZE;
 	ubi->leb_start = ALIGN(ubi->leb_start, ubi->min_io_size);
 
 	dbg_msg("vid_hdr_offset   %d", ubi->vid_hdr_offset);
-- 
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/