linux-kernel - Re: [PATCH] usb otg: use atomic notifier instead of blocking notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimKfFAaOkCh_9EaUegYcv-rOVqvMCQ6t7qPbQeB@mail.gmail.com>
Date:	Fri, 21 Jan 2011 17:34:08 +0200
From:	Grazvydas Ignotas <notasas@...il.com>
To:	Heikki Krogerus <heikki.krogerus@...ia.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Mian Yousaf Kaukab <mian.yousaf.kaukab@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Felipe Balbi <balbi@...com>, Tejun Heo <tj@...nel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>, Hema HK <hemahk@...com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yang Ruirui <ruirui.r.yang@...to.com>,
	David Brownell <david-b@...bell.net>
Subject: Re: [PATCH] usb otg: use atomic notifier instead of blocking notifier

On Wed, Jan 19, 2011 at 12:33 PM, Heikki Krogerus
<heikki.krogerus@...ia.com> wrote:
> On Wed, Jan 19, 2011 at 05:20:11PM +0800, ext Yang Ruirui wrote:
>> --- linux-2.6.orig/include/linux/usb/otg.h      2011-01-17 09:39:11.000000000 +0800
>> +++ linux-2.6/include/linux/usb/otg.h   2011-01-19 16:38:06.649546989 +0800
>> @@ -74,7 +74,7 @@ struct otg_transceiver {
>>         void __iomem                    *io_priv;
>>
>>         /* for notification of usb_xceiv_events */
>> -       struct blocking_notifier_head   notifier;
>> +       struct atomic_notifier_head     notifier;
>>
>>         /* to pass extra port status to the root hub */
>>         u16                     port_status;
>> @@ -234,13 +234,13 @@ otg_start_srp(struct otg_transceiver *ot
>>  static inline int
>>  otg_register_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
>>  {
>> -       return blocking_notifier_chain_register(&otg->notifier, nb);
>> +       return atomic_notifier_chain_register(&otg->notifier, nb);
>>  }
>>
>>  static inline void
>>  otg_unregister_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
>>  {
>> -       blocking_notifier_chain_unregister(&otg->notifier, nb);
>> +       atomic_notifier_chain_unregister(&otg->notifier, nb);
>>  }
>>
>>  /* for OTG controller drivers (and maybe other stuff) */
>
> Is drivers/power/twl4030_charger.c ready for atomic notifiers?

No it is not, it's doing some i2c stuff. With twl4030 it's called from
threaded_irq in twl4030-usb instead of musb core and is working fine..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/