linux-kernel - Re: [REGRESSION] S3 resume on SandyBridge doesn't work with NX protection (5bd5a45)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D3A08F4.1050706@zytor.com>
Date:	Fri, 21 Jan 2011 14:30:12 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	matthieu castet <castet.matthieu@...e.fr>
CC:	Lin Ming <ming.m.lin@...el.com>, Oliver Neukum <oneukum@...e.de>,
	rjw@...k.pl, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Michal Marek <mmarek@...e.cz>, Yinghai Lu <yinghai@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Borislav Petkov <bp@...en8.de>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Siarhei Liakh <sliakh.lkml@...il.com>,
	Xuxian Jiang <jiang@...ncsu.edu>,
	Dave Airlie <airlied@...hat.com>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] S3 resume on SandyBridge doesn't work with NX protection
 (5bd5a45)

On 01/21/2011 02:17 PM, matthieu castet wrote:
> Of course, but for example on x64, using smp trampoline to exit rm wakecode help
> to merge code in one place.

Yes, and there are numerous cleanups like that that can be done.

> Also the start of 32/64 bits trampoline (rm part) is really similar. The main difference is the verify_cpu
> check, but can't it be called latter (when we switch to 64 bits ) ?

One can *sometimes* do merges like that, but one has to be careful to
not make the code more complex instead of less by mistake.  Minor code
duplication is better than really ugly code.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/