linux-kernel - Re: [PATCH 0/7] Nexus One Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110121234930.GK3043@thunk.org>
Date:	Fri, 21 Jan 2011 18:49:30 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Daniel Walker <dwalker@...eaurora.org>,
	Dima Zavin <dmitriyz@...gle.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Joe Perches <joe@...ches.com>, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	davidb@...eaurora.org
Subject: Re: [PATCH 0/7] Nexus One Support

On Fri, Jan 21, 2011 at 11:05:54PM +0200, Pekka Enberg wrote:
> 
> On Fri, Jan 21, 2011 at 10:49 PM, Daniel Walker <dwalker@...eaurora.org> wrote:
> > I'll add this list into the commit text ..
> 
> So why is everyone bitching at Daniel when he's doing something the
> Android folks should have done themselves a long time ago?

Two wrongs don't make a right.  And it's not like not submitting
changes is wrong, although granted it's not ideal.  (I'd say removing
attribution from a git commit is even worse.  If you're doing the
equivalent of a cherry pick, you should preserve the Author field.
Even if you're doing some cleanup work, as the maintainer I generally
preserve the Author line, and will simply add the fact that I did some
cleanup to the commit body.  The question is who did more work; the
person who originally submitted the code, or the person who did the
cleanup.)

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/