linux-kernel - Re: [PATCH 1/3] selinux: return -ENOMEM when memory allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1101211101150.14355@tundra.namei.org>
Date:	Fri, 21 Jan 2011 11:07:13 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Davidlohr Bueso <dave@....org>
cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	LKML <linux-kernel@...r.kernel.org>, selinux@...ho.nsa.gov
Subject: Re: [PATCH 1/3] selinux: return -ENOMEM when memory allocation
 fails

On Thu, 20 Jan 2011, Davidlohr Bueso wrote:

> From: Davidlohr Bueso <dave@....org>
> 
> Signed-off-by: Davidlohr Bueso <dave@....org>
> ---
>  security/selinux/ss/conditional.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
> index c3f845c..a533732 100644
> --- a/security/selinux/ss/conditional.c
> +++ b/security/selinux/ss/conditional.c
> @@ -178,7 +178,7 @@ int cond_init_bool_indexes(struct policydb *p)
>  	p->bool_val_to_struct = (struct cond_bool_datum **)
>  		kmalloc(p->p_bools.nprim * sizeof(struct cond_bool_datum *), GFP_KERNEL);
>  	if (!p->bool_val_to_struct)
> -		return -1;
> +		return -ENOMEM;
>  	return 0;

The caller has already set -ENOMEM, so the code should probably be updated 
there, too, e.g.

	rc = cond_init_bool_indexes();
	if (rc)
		goto out;



-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/