linux-kernel - Re: [PATCH 3/3] Fix the wrong corrupted page information of hugetlb page.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110121051251.GA16406@spritzera.linux.bs1.fc.nec.co.jp>
Date:	Fri, 21 Jan 2011 14:12:51 +0900
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Jin Dongming <jin.dongming@...css.fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Huang Ying <ying.huang@...el.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] Fix the wrong corrupted page information of hugetlb
 page.

Hi,

> @@ -991,18 +995,32 @@ int __memory_failure(unsigned long pfn, int trapno, int flags)
>  			action_result(pfn, "free buddy", DELAYED);
>  			return 0;
>  		} else if (PageHuge(hpage)) {
> -			/*
> -			 * Check "just unpoisoned", "filter hit", and
> -			 * "race with other subpage."
> -			 */
>  			lock_page_nosync(hpage);
> -			if (!PageHWPoison(p)
> -			    || (hwpoison_filter(p) && TestClearPageHWPoison(p))
> -			    || (p != hpage && TestSetPageHWPoison(hpage))) {
> -				atomic_long_sub(nr_pages, &mce_bad_pages);
> +			/* Check "just unpoisoned". */
> +			if (!PageHWPoison(hpage)) {
                                          ^^^^^
Isn't this "p" (as you changed in patch 2/3) ?

-- Naoya Horiguchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/