linux-kernel - Re: [PATCH 1/3] mmc: add per device quirk placeholder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTik=R=VtaHrUCg_1oAXzjKy7XCBpCsEWTrq3=sNt@mail.gmail.com>
Date:	Sun, 23 Jan 2011 00:55:22 +0200
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	Pierre Tardy <tardyp@...il.com>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pierre Tardy <pierre.tardy@...el.com>
Subject: Re: [PATCH 1/3] mmc: add per device quirk placeholder

On Sun, Jan 9, 2011 at 6:26 PM, Pierre Tardy <tardyp@...il.com> wrote:
> From: Pierre Tardy <pierre.tardy@...el.com>
>
> Some cards have quirks valid for every platforms
> using current platform quirk hooks leads to a lot
> of code and debug duplication.
>
> So we inspire a bit from what exists in PCI subsystem
> and do our own per vendorid/deviceid quirk
> We still drop the complexity of the pci quirk system
> (with special section tables, and so on)
> That can be added later if needed.

I like this.

It's exactly what we need for the wl12xx, so thanks for pushing this.

I'm not sure about the necessity of the function hooks though - it
just looks like complexity that we don't really need, and I would
rather have this framework directly set the required quirks like USB
is doing. I do see the benefit it provides you with the gating
framework and the SDIO set/unset issue, and I don't have a cleaner
alternative approach, so I guess we can live with it.

Acked-by: Ohad Ben-Cohen <ohad@...ery.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/