linux-kernel - Re: SELinux/SMACK/TOMOYO: ioctl permissions handling is wrong andnonsensicle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1295662551.2914.0.camel@localhost.localdomain>
Date:	Fri, 21 Jan 2011 21:15:49 -0500
From:	Eric Paris <eparis@...hat.com>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: SELinux/SMACK/TOMOYO: ioctl permissions handling is wrong
 andnonsensicle

On Sat, 2011-01-22 at 11:01 +0900, Tetsuo Handa wrote:
> Eric Paris wrote:
> > I'm planning to revert this SELinux commit, but I want other LSM authors
> > to realize that (assuming I'm not completely off in the woods somewhere)
> > you should take a look at your ioctl permissions checking as well....
> 
> Since the mapping of ioctl cmd number and what the kernel does with that number
> is unknown for LSM modules, TOMOYO does not use permission bits.
> TOMOYO simply checks ioctl cmd number value passed to ioctl() requests.
> For example,
> 
>   file ioctl /dev/tty0 0x4B4E
>   file ioctl /dev/console 0x5402
>   file ioctl /dev/snd/controlC0 0x80045500
>   file ioctl socket:[family=2:type=1:protocol=6] 0x8942
>   file ioctl socket:[family=2:type=2:protocol=17] 0x8913
> 
>   http://tomoyo.sourceforge.jp/cgi-bin/lxr/source/centos5.5/domain_policy.conf?v=policy-sample
> 
> So, I think nothing to change for TOMOYO.

You are correct, I thought I saw you guys doing something similar, but
that is clearly not the case.  It's just SELinux and SMACK that are
doing it wrong.

-Eric


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/