linux-kernel - Re: [PATCH] drm/i915: Disable high-precision vblank timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <B3CD294C-4F91-4249-A5C5-2453B938F9BB@tuebingen.mpg.de>
Date:	Sun, 23 Jan 2011 17:41:07 +0100
From:	Mario Kleiner <mario.kleiner@...bingen.mpg.de>
To:	dri-devel@...ts.freedesktop.org
Cc:	Chris Wilson <chris@...is-wilson.co.uk>, chris2553@...glemail.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915: Disable high-precision vblank timestamping

> ------------------------------
>
> Message: 10
> Date: Sun, 23 Jan 2011 10:50:01 +0000
> From: Chris Wilson <chris@...is-wilson.co.uk>
> Subject: [PATCH] drm/i915: Disable high-precision vblank timestamping
> 	for UMS
> To: Chris Clayton <chris2553@...glemail.com>
> Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
> Message-ID:
> 	<1295779801-8118-1-git-send-email-chris@...is-wilson.co.uk>
>
> We only have sufficient information for accurate (sub-frame)  
> timestamping
> when the modesetting is under our control.
>
> Reported-by: Chris Clayton <chris2553@...glemail.com>
> Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_drv.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/ 
> i915_drv.c
> index 59eb19b..66796bb 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -752,6 +752,9 @@ static int __init i915_init(void)
>  		driver.driver_features &= ~DRIVER_MODESET;
>  #endif
>
> +	if (!(driver.driver_features & DRIVER_MODESET))
> +		driver.get_vblank_timestamp = NULL;
> +
>  	return drm_init(&driver);
>  }
>
> -- 
> 1.7.2.3
>
>


Oops! Have missed that. Thanks for fixing it.

Reviewed-by: Mario Kleiner <mario.kleiner@...bingen.mpg.de>


*********************************************************************
Mario Kleiner
Max Planck Institute for Biological Cybernetics
Spemannstr. 38
72076 Tuebingen
Germany

e-mail: mario.kleiner@...bingen.mpg.de
office: +49 (0)7071/601-1623
fax:    +49 (0)7071/601-616
www:    http://www.kyb.tuebingen.mpg.de/~kleinerm
*********************************************************************
"For a successful technology, reality must take precedence
over public relations, for Nature cannot be fooled."
(Richard Feynman)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/