linux-kernel - Re: [PATCH] i2c: octeon: Make the timeout 1*HZ instead of 1 jiffy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D3D7290.9050203@corscience.de>
Date:	Mon, 24 Jan 2011 13:37:36 +0100
From:	Bernhard Walle <walle@...science.de>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	ben-linux@...ff.org, ddaney@...iumnetworks.com,
	ralf@...ux-mips.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: octeon: Make the timeout 1*HZ instead of 1 jiffy

Hi Jean,

Am 24.01.2011 13:14, schrieb Jean Delvare:
>>  	.owner = THIS_MODULE,
>>  	.name = "OCTEON adapter",
>>  	.algo = &octeon_i2c_algo,
>> -	.timeout = 2,
>> +	.timeout = HZ,
>>  };
> 
> This is a large timeout value, much larger than any value the
> i2c-octeon driver was using today for any possible value of HZ.
> Wouldn't it make more sense to set it to HZ / 50, which is 2 for HZ =
> 100, leaving the setting unchanged for this common case at least?

To be honest, I had problems with timeout=2 that go away with
timeout=HZ. But I cannot be sure that this is a problem with my hardware
that is not present with other devices.

The drivers that use HZ are i2c-mpc.c and i2c-pca-platform.c, but I
don't know the hardware that much so that I really can compare the values.

So yes, you're right. A patch modifying the timeout value should be an
extra patch, so I will resend the current patch to use HZ/50.

Regards,
Bernhard

Download attachment "signature.asc" of type "application/pgp-signature" (901 bytes)