| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110124144142.GA16813@sirena.org.uk> Date: Mon, 24 Jan 2011 14:41:43 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Colin Cross <ccross@...roid.com> Cc: linux-tegra@...r.kernel.org, Russell King <linux@....linux.org.uk>, konkers@...roid.com, linux-kernel@...r.kernel.org, olof@...om.net, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 20/28] ARM: tegra: cpufreq: Disable cpufreq during suspend On Sun, Jan 23, 2011 at 06:01:25PM -0800, Colin Cross wrote: > Adds a SUSPEND_PREPARE notification hook to drop the frequency to > the lowest possible during suspend. This prevents the cpufreq driver > from attempting regulator calls after suspend has started - the > regulator api can call into drivers that have already been suspended. Hrm, what's the situation where that happens and why does it cause problems? The regulator API doesn't care if suspend is going on, and nor do any of the current drivers for regulators. There is an issue with keeping things like I2C alive until the bitter end of suspend so you've got a control bus to the regulators but that's a generic issue which crops up with other subsystems too so a regulator-specific workaround seems dodgy. The patch itself seems fine, it's just that it feels like there's something else going on. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists