linux-kernel - Re: [PATCH] xen-pcifront: don't use flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110124155241.GB27510@htj.dyndns.org>
Date:	Mon, 24 Jan 2011 16:52:41 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	Ryan Wilson <hap9@...ch.ncsc.mil>,
	Jan Beulich <JBeulich@...ell.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH] xen-pcifront: don't use flush_scheduled_work()

Sorry, missed the later part.

On Mon, Jan 24, 2011 at 10:39:58AM -0500, Konrad Rzeszutek Wilk wrote:
> > -	/*For PCIE_AER error handling job*/
> 
> Any reason for getting rid of the comment?
> 
> > -	flush_scheduled_work();
> > +	cancel_work_sync(&pdev->op_work);

Because it's obvious from the code now.  If you think it's better to
keep the comment, I have no objection whatsoever.

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/