linux-kernel - Re: [PATCH 10/10] fs: make aio plug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x497hdugp32.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 24 Jan 2011 12:59:29 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	linux-kernel@...r.kernel.org, hch@...radead.org,
	Shaohua Li <shaohua.li@...el.com>
Subject: Re: [PATCH 10/10] fs: make aio plug

Jens Axboe <jaxboe@...ionio.com> writes:

> From: Shaohua Li <shaohua.li@...el.com>
>
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
> Signed-off-by: Jens Axboe <jaxboe@...ionio.com>
> ---
>  fs/aio.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index c5ea494..1476bed 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1660,6 +1660,7 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>  	long ret = 0;
>  	int i;
>  	struct hlist_head batch_hash[AIO_BATCH_HASH_SIZE] = { { 0, }, };
> +	struct blk_plug plug;
>  
>  	if (unlikely(nr < 0))
>  		return -EINVAL;
> @@ -1676,6 +1677,8 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>  		return -EINVAL;
>  	}
>  
> +	blk_start_plug(&plug);
> +
>  	/*
>  	 * AKPM: should this return a partial result if some of the IOs were
>  	 * successfully submitted?
> @@ -1698,6 +1701,7 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>  		if (ret)
>  			break;
>  	}
> +	blk_finish_plug(&plug);
>  	aio_batch_free(batch_hash);

I'm pretty sure you want blk_finish_plug to run after aio_batch_free.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/