linux-kernel - Re: [PATCH 01/16] x86: Kill unused static boot_cpu_logical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimPZUzhMB08ikJ_uZLk9iteJ6PdgvbGq9yWa2vO@mail.gmail.com>
Date:	Mon, 24 Jan 2011 11:50:39 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	tglx@...utronix.de, x86@...nel.org, eric.dumazet@...il.com,
	brgerst@...il.com, gorcunov@...il.com, penberg@...nel.org,
	shaohui.zheng@...el.com, rientjes@...gle.com
Subject: Re: [PATCH 01/16] x86: Kill unused static boot_cpu_logical_apicid in smpboot.c

On Sun, Jan 23, 2011 at 5:37 AM, Tejun Heo <tj@...nel.org> wrote:
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Reviewed-by: Pekka Enberg <penberg@...nel.org>
> ---
>  arch/x86/kernel/smpboot.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 763df77..c255980 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -165,8 +165,6 @@ static void unmap_cpu_to_node(int cpu)
>  #endif
>
>  #ifdef CONFIG_X86_32
> -static int boot_cpu_logical_apicid;
> -
>  u8 cpu_2_logical_apicid[NR_CPUS] __read_mostly =
>                                        { [0 ... NR_CPUS-1] = BAD_APICID };
>
> @@ -1096,9 +1094,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
>         * Setup boot CPU information
>         */
>        smp_store_cpu_info(0); /* Final full version of the data */
> -#ifdef CONFIG_X86_32
> -       boot_cpu_logical_apicid = logical_smp_processor_id();
> -#endif
> +
>        current_thread_info()->cpu = 0;  /* needed? */
>        for_each_possible_cpu(i) {
>                zalloc_cpumask_var(&per_cpu(cpu_sibling_map, i), GFP_KERNEL);

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/