linux-kernel - Re: [PATCH] sched: fix autogroup nice tune on UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimea-ZFP8UzPTHuu9pqghq4+NCP76KsPJMvpwRL@mail.gmail.com>
Date:	Mon, 24 Jan 2011 11:17:34 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Michael Witten <mfwitten@...il.com>,
	linux-kernel@...r.kernel.org,
	Christian Kujau <christian@...dbynature.de>,
	Mike Galbraith <efault@....de>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] sched: fix autogroup nice tune on UP

On Sun, Jan 23, 2011 at 11:16 PM, Pekka Enberg <penberg@...nel.org> wrote:
>> tg->se->load, the reason is update_cfs_shares()
>> do nothing on SMP.
>
> Typo here? You mean UP, right?

Ah, Yeah. Thanks for pointing it.



>
> I'm not an expert on the scheduler but this looks like the wrong thing
> to do. Shouldn't you fix update_cfs_shares() to work on UP properly?
>

I have through about that. No-poking on update_cfs_shares() is because
update_cfs_shares() is called at several hot path, like enqueue_entity()/
dequeue_entity(), but it doesn't make sense on UP.

But I guess you are right. We still need to update the load of cfs_rq
after update_load_set() is called even on UP, so
update_cfs_shares() is the suitable place to do that.

Will take another look at update_cfs_shares().

Thanks,
Yong

-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/