linux-kernel - RE: [PATCH v6] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000601cbbc91$cf9d8d80$6ed8a880$@org>
Date:	Tue, 25 Jan 2011 15:14:31 +0200
From:	"Tanya Brokhman" <tlinder@...eaurora.org>
To:	"'Alan Stern'" <stern@...land.harvard.edu>
Cc:	<gregkh@...e.de>, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>,
	"'David Brownell'" <dbrownell@...rs.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd

> On Thu, 18 Nov 2010, Tatyana Brokhman wrote:
> 
> > USB 3.0 hub includes 2 hubs - HS and SS ones.
> > Thus, when dummy_hcd enabled it will register 2 root hubs (SS and
> HS).
> 
> Hmm.  A quick comparison with the original source shows that you
> neglected to add code for SuperSpeed transfers to periodic_bytes() and
> show_urb().

Added in the next patch that will be uploaded soon.

> 
> > @@ -1352,6 +1544,9 @@ static void dummy_timer (unsigned long _dum)
> >  	case USB_SPEED_HIGH:
> >  		total = 512/*bytes*/ * 13/*packets*/ * 8/*uframes*/;
> >  		break;
> > +	case USB_SPEED_SUPER:
> > +		total = 400 << 20; /* 400MB = 400*(2^20) bytes */
> > +		break;
> 
> Somehow I doubt that SuperSpeed USB, quick though it is, can transfer
> 400 MB in one millisecond.  Where did you get that number from?
> 

>From USB3.0 Spec section 4.4.11. My mistake was that this value (400 << 20)
is per sec and not per milisec. When we divide it by 1000 (milisec) we'll
receive a value close to what you suggested bellow. Fixed.

> I can't find the appropriate table in the USB-3.0 spec (it might not be
> there at all), but with a bus transfer rate of 500 million bytes/s it
> seems clear that you can't transfer more than 500000 bytes per frame.
> The actual limit must be lower than that, maybe something like 1024
> bytes/packet * 60 packets/uframe * 8 uframes/frame = 491520
> bytes/frame.
> 
> Alan Stern

Sorry for the poor quoting (this mail is a bit old) and the late response.
Our intention was to release the unittests we used to test this
implementation with the next patch version but releasing them got delayed
due to legal issues.

Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/