linux-kernel - Re: [RFC] [PATCH 2.6.37-rc5-tip 12/20] 12: uprobes: get the breakpoint address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295963781.28776.1060.camel@laptop>
Date:	Tue, 25 Jan 2011 14:56:21 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-mm <linux-mm@...r.kernel.org>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	SystemTap <systemtap@...rces.redhat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 12/20] 12: uprobes: get the
 breakpoint address.

On Thu, 2010-12-16 at 15:29 +0530, Srikar Dronamraju wrote:
> On a breakpoint hit, perform a architecture specific calculation to
> return the address where the breakpoint was hit.

And yet all the code added is generic ;-)

> Signed-off-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> Signed-off-by: Jim Keniston <jkenisto@...ibm.com>
> ---
>  include/linux/uprobes.h |    5 +++++
>  kernel/uprobes.c        |   11 +++++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
> index a631c42..ee12b2e 100644
> --- a/include/linux/uprobes.h
> +++ b/include/linux/uprobes.h
> @@ -154,6 +154,7 @@ extern void uprobe_free_utask(struct task_struct *tsk);
>  
>  struct vm_area_struct;
>  extern void uprobe_mmap(struct vm_area_struct *vma);
> +extern unsigned long uprobes_get_bkpt_addr(struct pt_regs *regs);
>  extern void uprobe_dup_mmap(struct mm_struct *old_mm, struct mm_struct *mm);
>  extern void uprobes_free_xol_area(struct mm_struct *mm);
>  #else /* CONFIG_UPROBES is not defined */
> @@ -173,5 +174,9 @@ static inline void uprobe_dup_mmap(struct mm_struct *old_mm,
>  static inline void uprobe_free_utask(struct task_struct *tsk) {}
>  static inline void uprobe_mmap(struct vm_area_struct *vma) { }
>  static inline void uprobes_free_xol_area(struct mm_struct *mm) {}
> +static inline unsigned long uprobes_get_bkpt_addr(struct pt_regs *regs)
> +{
> +	return 0;
> +}
>  #endif /* CONFIG_UPROBES */
>  #endif	/* _LINUX_UPROBES_H */
> diff --git a/kernel/uprobes.c b/kernel/uprobes.c
> index 09e36f6..f486c4f 100644
> --- a/kernel/uprobes.c
> +++ b/kernel/uprobes.c
> @@ -976,6 +976,17 @@ static void xol_free_insn_slot(struct task_struct *tsk, unsigned long slot_addr)
>  						__func__, slot_addr);
>  }
>  
> +/**
> + * uprobes_get_bkpt_addr - compute address of bkpt given post-bkpt regs
> + * @regs: Reflects the saved state of the task after it has hit a breakpoint
> + * instruction.
> + * Return the address of the breakpoint instruction.
> + */
> +unsigned long uprobes_get_bkpt_addr(struct pt_regs *regs)
> +{
> +	return instruction_pointer(regs) - UPROBES_BKPT_INSN_SIZE;
> +}
> +
>  /*
>   * Called with no locks held.
>   * Called in context of a exiting or a exec-ing thread.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/