linux-kernel - Re: [PATCH v2 28/28] ARM: tegra: clock: Add forward reference to struct clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=Ar7dAtRHj=uZ9a+CGSaU4FhJA92+AyHoJcrcH@mail.gmail.com>
Date:	Mon, 24 Jan 2011 17:23:30 -0800
From:	Colin Cross <ccross@...roid.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	linux-tegra@...r.kernel.org, konkers@...roid.com,
	linux-kernel@...r.kernel.org, olof@...om.net,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 28/28] ARM: tegra: clock: Add forward reference to
 struct clk

On Mon, Jan 24, 2011 at 2:26 AM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Sun, Jan 23, 2011 at 06:01:33PM -0800, Colin Cross wrote:
>> diff --git a/arch/arm/mach-tegra/include/mach/clkdev.h b/arch/arm/mach-tegra/include/mach/clkdev.h
>> index 412f5c6..66cd3f4 100644
>> --- a/arch/arm/mach-tegra/include/mach/clkdev.h
>> +++ b/arch/arm/mach-tegra/include/mach/clkdev.h
>> @@ -20,6 +20,8 @@
>>  #ifndef __MACH_CLKDEV_H
>>  #define __MACH_CLKDEV_H
>>
>> +struct clk;
>> +
>>  static inline int __clk_get(struct clk *clk)
>>  {
>>       return 1;
>
> If you're having to add that, I suspect this include is being
> inappropriately included by files.
>

The Tegra clock definition file, arch/arm/mach-tegra/tegra2_clocks.c,
includes the private clock.h that defines struct clk after including
linux/clkdev.h, and does not include linux/clk.h, so the forward
declaration is necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/