linux-kernel - Re: [PATCH 16/16] KVM-GST: adjust scheduler cpu power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295989664.28776.1124.camel@laptop>
Date:	Tue, 25 Jan 2011 22:07:44 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Glauber Costa <glommer@...hat.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	aliguori@...ibm.com, Rik van Riel <riel@...hat.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH 16/16] KVM-GST: adjust scheduler cpu power

On Tue, 2011-01-25 at 18:47 -0200, Glauber Costa wrote:
> On Tue, 2011-01-25 at 21:13 +0100, Peter Zijlstra wrote:
> > On Tue, 2011-01-25 at 18:02 -0200, Glauber Costa wrote:
> > 
> > > I fail to see how does clock_task influence cpu power.
> > > If we also have to touch clock_task for better accounting of other
> > > stuff, it is a separate story.
> > > But for cpu_power, I really fail. Please enlighten me.
> > 
> > static void update_rq_clock_task(struct rq *rq, s64 delta)
> > {
> >         s64 irq_delta;
> > 
> >         irq_delta = irq_time_read(cpu_of(rq)) - rq->prev_irq_time;
> > 
> >         if (irq_delta > delta)
> >                 irq_delta = delta;
> > 
> >         rq->prev_irq_time += irq_delta;
> >         delta -= irq_delta;
> >         rq->clock_task += delta;
> > 
> >         if (irq_delta && sched_feat(NONIRQ_POWER))
> >                 sched_rt_avg_update(rq, irq_delta);
> > }
> > 
> > its done through that sched_rt_avg_update() (should probably rename
> > that), it computes a floating average of time not spend on fair tasks.
> > 
> It creates a dependency on CONFIG_IRQ_TIME_ACCOUNTING, though.
> This piece of code is simply compiled out if this option is disabled.

We can pull this bit out and make the common bit also available for
paravirt.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/