linux-kernel - Re: [PATCH 4/4] msm: clock: Add support for more proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295992703.25496.72.camel@c-dwalke-linux.qualcomm.com>
Date:	Tue, 25 Jan 2011 13:58:23 -0800
From:	Daniel Walker <dwalker@...eaurora.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Saravana Kannan <skannan@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart,
> and i2c clocks on targets which support proc_comm clocks.

Basically when you catch yourself writing "also" in the commit text you
need to re-evaluate making two patches.. In this case it looks
appropriate..

I'd do CE_CLK and CODEC_SSBI_CLK in one, with the increment for the
number of clocks, and adding those two clocks.

Then the rest of it I'm not sure. If it was me I'd break out uart and
i2c in different patches but that might be overkill.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/