linux-kernel - Re: [RFC] [PATCH 2.6.37-rc5-tip 4/20] 4: uprobes: Adding and remove a uprobe in a rb tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110126084522.GF19725@linux.vnet.ibm.com>
Date:	Wed, 26 Jan 2011 14:15:22 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Christoph Hellwig <hch@...radead.org>,
	Andi Kleen <andi@...stfloor.org>,
	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	SystemTap <systemtap@...rces.redhat.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 4/20]  4: uprobes: Adding and
 remove a uprobe in a rb tree.

* Peter Zijlstra <peterz@...radead.org> [2011-01-25 14:56:13]:

> On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
> > +struct uprobe_consumer {
> > +       int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs);
> > +       /*
> > +        * filter is optional; If a filter exists, handler is run
> > +        * if and only if filter returns true.
> > +        */
> > +       bool (*filter)(struct uprobe_consumer *self, struct task_struct *task);
> > +
> > +       struct uprobe_consumer *next;
> > +       void *fvalue;   /* filter value */
> > +}; 
> 
> Since you pass in a pointer to this structure at register_uprobe() its
> user allocated, hence you can remove the fvalue thing and let the user
> embed this in a larger struct if needed, the filter functions can then
> use container_of() to get at the larger data structure.


Okay, Will do, but Is there a reason for moving the fvalue out of the
uprobe_consumer? Except for reducing the size of the structure, I am
unable to see advantage.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/