linux-kernel - Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and fork hooks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110126090643.GI19725@linux.vnet.ibm.com>
Date:	Wed, 26 Jan 2011 14:36:43 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Christoph Hellwig <hch@...radead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Oleg Nesterov <oleg@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	SystemTap <systemtap@...rces.redhat.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20]  8: uprobes: mmap and fork
 hooks.

* Steven Rostedt <rostedt@...dmis.org> [2011-01-25 15:05:26]:

> On Tue, 2011-01-25 at 13:15 +0100, Peter Zijlstra wrote:
> > On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
> 
> > > +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> > > +               struct list_head *tmp_list)
> > > +{
> > > +       struct rb_node *p;
> > > +
> > > +       if (p)
> > > +               __search_within_subtree(p, inode, tmp_list);
> > > +
> > > +       p = n->rb_right;
> > > +       if (p)
> > > +               __search_within_subtree(p, inode, tmp_list);
> > > +} 
> > 
> > Whee recursion FTW!, you just blew your kernel stack :-)
> > 
> > Since you sort inode first, offset second, I think you can simply look
> > for the first matching inode entry and simply rb_next() until you don't
> > match.
> 
> Not to mention that p is uninitialized. Did this code ever work?

I think the original patch that I sent had p initialized. I think it got
dropped off by Peter when he replied. Please do confirm.


-- 
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/