[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110126093051.GA12520@htj.dyndns.org>
Date: Wed, 26 Jan 2011 10:30:51 +0100
From: Tejun Heo <tj@...nel.org>
To: "Darrick J. Wong" <djwong@...ibm.com>
Cc: Vivek Goyal <vgoyal@...hat.com>, axboe@...nel.dk, tytso@....edu,
shli@...nel.org, neilb@...e.de, adilger.kernel@...ger.ca,
jack@...e.cz, snitzer@...hat.com, linux-kernel@...r.kernel.org,
kmannth@...ibm.com, cmm@...ibm.com, linux-ext4@...r.kernel.org,
rwheeler@...hat.com, hch@....de, josef@...hat.com
Subject: Re: [PATCH 1/3] block: Create sysfs knobs to override FLUSH/FUA
support flags
On Tue, Jan 25, 2011 at 11:16:26PM -0800, Darrick J. Wong wrote:
> This patch is the first in a series to refactor the barrier= mount options out
> of the filesystem code. This patch adds sysfs knobs to disable flush and FUA;
> of course, the automatic default is the safe choice, i.e. to leave them
> enabled. Obviously, only a seasoned administrator should ever be overriding
> the defaults.
Hmmm... wouldn't it be better to just export flush and fua instead of
ignore_*? So that the admin can turn things on and off as [s]he seems
fit? Also, it might be better to export them in a single attribute,
say cache_control or something. Only subset of the combinations make
sense anyway - none, flush, flush_fua.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists